tools: fix release proposal linter to support more than 1 folk preparing #56203
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
richardlau
approved these changes
Dec 10, 2024
marco-ippolito
approved these changes
Dec 10, 2024
aduh95
added
author ready
RafaelGSS
approved these changes
Dec 10, 2024
jasnell
approved these changes
Dec 11, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 37766dc |
targos
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56203 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
aduh95
added a commit
that referenced
this pull request
Dec 18, 2024
PR-URL: #56203 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the person preparing the release is not the person promoting it, there are more than 1
@char and the linter should account for that.in this case, it's a matter of using
%%instead of%bash parameter expansion. I'm also changing the test syntax to align with how our.shfiles linter is set even though it's not running on shell script written inside YAML files.